pfSense

Use dnctl(8) to control limiter rules. Feature #12579

Captive Portal ipfw->pf transition. Todo #13100

Merge pull request #4549 from hpeters/master

Update the Copyright year of the files owned by Rubicon/Netgate.

#12003 Prevent some pie aqm and fq_pie scheduler settings from being saved with limiters not using pie aqm or fq_pie scheduler.

#12003 This commit adds missing settings, zero and floating point support for those settings to the limiter scheduler fq_pie.

Mute kernel messages on dummynet and thermal hardware modules load. Fixes #12454

CODELQ scheduler Qlimit input validation. Issue #11725

Add cronjob only for limiters applied to firewall rules. Fixes #11636

Update the Copyright year.

A subsequent commit will deal with .po's.

Add product_label global variable

Introduce product_label global variable, by default with same value of
product_name. The idea is to make it easier for rebranded products to
change the name on all visual texts while internal structures are
preserved.

While here, remove deprecated $g['platform'] and also replace places...

CBQ borrow option input validation. Issue #7915

Traffic shaper wizard fix. Issue #10998

Nested queues input validatin fix. Issue #10998

CBQ queue prio check fix. Issue #1353

Default queue bw scale in Mbit/s. Feature #10988

Update URLs to docs. Fixes #10481

Remove commented out line

Merge pull request #4400 from bonald/master

Set net.inet.ip.dummynet sysctl. Fixes #10780

Add build_mask_rules for scheduler

before:
sched 7 config pipe 7 type fq_codel target 5ms interval 100ms quantum 300 limit 20480 flows 65535 noecn

after:
sched 7 config pipe 7 mask dst-ip6 /128 dst-ip 0xffffffff type fq_codel target 5ms interval 100ms quantum 300 limit 20480 flows 65535 noecn

Merge pull request #4388 from vktg/limmbits

Limiter default bw type in Mbit/s. Implements #10727

Shaper check prio only for CBQ/FAIRQ/PRIQ. Issue #1353

Merge pull request #4358 from vktg/shaperpriqcheck

Shaper root queue percent bw fix. Issue #10660

PRIQ queue array check. Issue #1353

Merge pull request #4327 from vktg/prioinputvalid

Fix syntax error in shaper.inc

PRIQ queue input validation. Issue #1353

Limiters/queues rename/delete fix. Issue #3924

Merge pull request #4287 from vktg/rednoencfix

RED/GRED limiters do not have noecn option. Issue #10211

Improve help message for limiter/queue masks.

The user-facing most important change is that when setting masks on
Queues, we are not creating dynamic pipes (but queues).

The second change mentions that besides per-host bandwidth limits this
is helpful for per-subnet Queues/pipes....

Link to the book, not old OpenBSD docs. Fixes #10184

This is 2020. Issue #9245

simplify queue stats parser

support variable value length in queue stats parser

Enforce limiter delay 0<=x<=10000. Fixes #9921

Fix copyright message years to reflect BSDP -> ESF -> Netgate

Encode shaper queue name before printing. Issue #9294

Validation is already present and prevents bad values from being
entered.

Update copyright notices to 2019. Happy New Year

Make the WF2Q+ the default scheduler for the dummynet limiters.

The WF2Q+ was the default scheduler in previous versions, it is well tested and support dynamic queues.

Add a note for the FIFO scheduler to make clear that it does not support dynamic queues (by design) and as such, it is working as intended....

Fix #9121: Initialize arrays to prevent PHP 7 errors

Fix Limiter validation check, which allows old queues to display. Fixes #8956

The AQM defaults to droptail when empty, but empty was being rejected as
invalid even though it was handled in the code.

PHP7 related, cast bandwitdh to int to make sure it is a numeric value Fixes #8757

Fix shaper "non-numeric value" errors

Merge pull request #3941 from mattund/master

Fixing @jim-p's change requests

Fixing GitHub reported issues

PHP7 fixed illegal string offset

Fixed #8515 fixed error in queue defintion where it would repeat

It should now create a new definition for each queue. Queues should
now show up under status > queues.

1. I rewound src/etc/inc/config.inc back to you guys' base. It was some funny EOL stuff that happened.
2. Unwrapped gettext()
3. Agreed. Sanitized.
4. Unwrapped gettext()
5. Took out input_errors item
6. Took out input_errors item
7. I like the idea of this. I would love to add heavier validation; unless I just affix for datatype I would need to know the constraints on which the parameters live for the AQM/scheds. Maybe that's documented. I can revisit this....

Fixed #8515 Queues should now be added either through manually creating them or through the wizard

PHP7 - Resolve count() error

Allow multiple Queues to be displayed for Limiters part of PHP 7.2 Migration

Also delete scheduler on cleanup

Setters and getters for $aqm/sched params (anticipating a review will request that)

Fix command syntax in format_parameters

CRLF

Fix newlines back

- Fix an incorrect assumption where I thought the sysctls were measured in ms. they appear to be microseconds instead (thanks Harvy66)
- Fix a problem where I was recursively assigning parameters in FormatParameters(), but that was not an ideal method (using vsprintf instead)...

Merge branch 'master' of gitlab.netgate.com:pfsense/pfsense

Change back to PHP7 compliance

- Fixed a bug where you could not get an ECN-incapable scheduler or AQM to work: noecn was appended in rules.limiter.
- Made a change to an array reference that was breaking my test

Wrote to wrong file.

Add dummynet AQM and scheduler configuration support to pfSense Limiters through the GUI. Only shaper.inc was changed.

Presently, the traffic shaper is versatile however outbound shaping can be tricky. This patch aims to solve that, allowing not only outgoing shaping through dummynet pipes but also enabling users to attach configurable shaping to virtually any interface. Right now, altq does not support LAGG ifaces, ixgbe, among others....

Remove references for new classes instances adding a temporary variable. We will revisit it later

PHP7 - Resolve illegal offset error

Revert "Do not assign classes with =& to make PHP 7 happy"

This reverts commit e33c96162a33b52a9152ce0b05dba8b25f1dc2b4.

Do not assign classes with =& to make PHP 7 happy

Fixed #8091 Force Integers in GUI
It will use the ceil() function to always use the ceiling after loading a config.
Also onchange of bandwidth will call the ceil function to put in a whole number.

off-by-one fix in an error text.

No functional change.

Update the Copyright notice for pfSense.

Merge pull request #3792 from PiBa-NL/20170731-status_queues-realtime

Ensure that the value passed to ipfw pipes is always an integer, no matter the source. Fixes #8097

status_queues, provide 'realtime' statistics
-retrieve 'current' numbers from pfSense

not using qstats provides the following advantages:
-no long lag which requires 18 updates to get 90% accurate values on screen
-showing queue's in 2 browsers does not show half the value...

Crudely fixed #7786 by eliminating check of parent bandwidth when children are sepcified in %

shaper, hfsc cannot use priority, as such don't show the field in the webgui.
Also for the other shapers 0 is a valid priority
While fairq causes a error loading rules with a priority above 7 so prevent that.

Fixed #7231

This avoids the problem rather than fixing it by requiring the user to remove any queues from the if before deleting

Remove HTML from translated shaper setHelp

and sections must not be translated - examples of IP address formats 255.255.255.255 and so on.

Require Name field in Shaper

Correct part of #6779
Setting input "step" value to "any" alows hte element to accept decimal (float) values, not just integers.

OpenBSD removed the pf FAQ page for shaping, so link to the proper page on archive.org since they offer no current equivalent and no other suitable replacement page is immediately available. Fixes #6781

Rework captive portal to run with stock IPFW (round 1)

- Remove use of IPFW context
- Create a rule that will skip to proper rule for each cp zone
- Use new PHP module functions wherever is possible

Move copyright from ESF to Netgate

Allow section header to be omitted by specifying "NOTITLE" as the section title.

Fixed #6437

Move to Apache License 2.0

Review license / copyright on all files (final round)

Review license / copyright on all files (1st round)

Set pipe_slot_limit to the maximum configured qlimit value. Move the set_sysctl out if the block where it only gets run if dummynet isn't already loaded. Ticket #6553

Clean up limiter text. Remove old commented out bit.

Customize limiter info message

The $dn_default_shaper_msg is what is displayed on the Limiters tab. It needs to talk about "limiter" rather than "queue".
This code builds up each message using the same base template sentences, inserting "queue" or "limiter" in the appropriate place.

Miscellaneous Textual Correction - Firewall / Shaper

Fix trivial GUI typo.

TRB should be TBR for "Token Bucket Regulator".

Includes - Remove Personalizations

Remove "you" personalizations.

Fix the sum of child bandwidth.

Now percentages are correctly handled.

Remove commented and unused old code supposed to do the same.

Ticket #5721

Disable the check of subqueues bandwidth until it is fixed.

Ticket #5721

Pass the correct variable to get_interface_bandwidth(). Fixes the boot crash reported by JimP.

Spotted by: Jorge Oliveira
Ticket #5721