pfSense

Checks for DHCP Relay being enabled/disabled should be skipped when editting an additional pool

Add missing $zone variable

Update BIND zones when adding static DHCP leases if needed (Bug #3710)

Check that DHCP registration isn't enabled for DNS forwarder/resolver when disabling DHCP server

GET/POST conversion - services part 1

setHelp strings for services*

Part Fix #7233 Allow deletion of empty static map entries

Required fields in Services pages

Display client id in DHCP Mapping list

Merge pull request #3369 from phil-davis/breadcrumbs_detail

Breadcrumb links

Report problems applying changes

1) Strictly keep track of the accumulating $retval from calls to various
functions that apply changes.
2) Use new function print_apply_result_box() to print a suitable message
in a suitable severity based on $retval

Merge pull request #3307 from blkeller/ignore-client-uids

Merge pull request #3248 from phil-davis/ipaddressnopattern

Modify DHCP Server messages

Customize DHCP Server on interfaces message

Fix field type for TFTP in DHCP server settings

Add new "Ignore client identifiers" DHCP feature

Exposes the underlying dhcpd configuration option "ignore-client-uids"
in the pfSense "Services / DHCP Server" GUI by adding an "Ignore client
identifiers" checkbox.

As of ISC dhcpd version 4.3.0+, there is a new configuration statement...

Disable DHCP server on interfaces with subnet >= 31. Fixes #6930

DHCP server edit when DHCP Relay enabled

Part of Redmine #6997
1) Display the DHCP Server settings even when DHCP Relay is enabled, but
disable the "enable" checkbox in this case - so the user cannot enable
DHCP Server when DHCP Relay is enabled, but can view and modify the DHCP...

Form_IpAddress add types remove patterns

1) Add alias and host types to Form_IpAddress with the appropriate hover
text.
2) Remove the patterns - the UI of those is not so effective anyway, so
leave the validation of input to the back end.
3) Update uses of Form_IpAddress to use the appropriate Alias or Host...

Clarified help text for ddnsforcehostname option.

Added title to ddnsforcehostname checkbox

Add ddnsforcehostname option to DHCP Server configuration editor

Improve IPv4 address validation for services_dhcp

The input pattern that goes with Form_IpAddress by default allows for IPv4 and IPv6 valid characters. The back-end validation here is checking for IPv4 addresses, so it seems reasonable that the front-end input pattern checks might as well be restricted to the IPv4 valid characters. Unneeded setPattern have also been removed....

Merge pull request #3151 from EdHurtig/eng/6806

Typo staic

Apply static ARP entries more consistently when adding and removing static mapping entries. Fixes #6821

Allow Hyphens in DHCP NTP Server form validation

Also removes the ability to have underscores `_` in ntp server
FQDNs.

Closes #6806

Move copyright from ESF to Netgate

Merge pull request #3083 from doktornotor/patch-2

services_dhcp: Ignore BOOTP queries

BOOTP leases do not have a maximum lease time by default, this could
potentially lead to a DHCP address pool exhaustion.

This commit adds an option to ignore BOOTP queries.

Redmine #4351

Allow URLs for TFTP Server (Bug #6634)

The setPattern() thing ain't usable for this and just causes regressions.

Typo fix

Allow URLs for TFTP Server (Bug #6634)

is_URL() from util.inc is way too limited for this purpose.

Clarify that HMAC-MD5 key is required. Ticket #6622

Move to Apache License 2.0

Review license / copyright on all files (final round)

Fix #6050 DHCP - provide Network Booting display/hide advanced button

This one moves the "Network Booting" above the "Additional BOOTP/DHCP Options". That allows "Network Booting" to be a Display/Hide Advanced group of buttons just like TFTP, LDAP etc. (without a special section header) and for "Additional BOOTP/DHCP Options" to come last on the page.

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Fixed #6504 by making table sortable

Allow - in TFTP Server field. Ticket #6433

Miscellanous Textual Corrections - Add missing dots, normalize case

Fix missing interface in pool edit. Ticket #6303

Hostnames are valid for NTP servers in DHCP Server. Ticket #6239

Services - Punctuation

Clean up some services menu punctuation.

Services / DHCP Server - DNS Servers Clarification

It reads as though the interfaces IP address is to be entered. Removing "use" makes it a little clearer.

Services / DHCP - Remove Personalizations

Remove "you" personalizations.

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

HTML Compliance - Services / DHCP Server

Error: The align attribute on the td element is obsolete. Use CSS instead.

servise_dhcp include btnadvopts in section

Before this change, $section is added to $form before btnadvopts is put into $section. The previous code looked to me like btnadvopts would end up in a $section object that got overwritten by the new Form_Section at line 1165....

Redmine #5994 Make DHCP advanced buttons work consistently

This is the first UI page to be changed so that the Advanced buttons work as specified in Redmine #5994
If this seems like a reasonable way to do it, then I will make similar code for the other UI pages with Advanced buttons.

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

Fix some Save button quirks. Ticket #5965

Advanced button consistency. Ticket #5965

More icon and button consistency fixes. Ticket #5965

Icon consistency in Repeatable blocks. Ticket #5965

Bring some consistency to the way most buttons are displayed (color, icons, etc). Ticket #5965

Still need to review Advanced buttons and Repeatable block buttons.

Check the end of range to make sure it's inside subnet too

Use high level functions

Simplify logic and use high level functions

Merge pull request #2409 from stilez/patch-13

Prevent "Ignore denied clients" and "Failover Peer IP" from being combined in the DHCP server settings for IPv4. The daemon fails to start when configured in this way, it apparently only allows "allow" or "deny" in failover mode. Fixes #5898

Merge pull request #2637 from k-paulius/patch-6

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Use print_info_box() to generate alerts

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Use print_info_box() to generate alerts

Show interface name in the breadcrumb on DHCP Server page

Convert section titles to title case

Convert section titles to title case

Redmine #4647 default DHCP server tab to a interface with DHCP enabled

This has also annoyed me, where WAN has a static IP. Every time I go to Services->DHCP I then have to click the LAN tab.
With this change it will look for a "reasonable" tab to go to:...

Apply current UI standard to DHCP Pools table

1) "Actions" column heading.
2) Make action buttons fa-pencil fa-trash
3) Put a title for each button, so that the "Are you sure you wish to..." popup works nicely.

Standardize print_apply_box usage

1) For the translators, it should be better to do it consistently. Then
they only need to have 1 translation of "You must apply the changes in
order for them to take effect" and can translate each of the other
custom sentences individually....

Internationalize services_d*

Merge pull request #2025 from apilloud/dhcp-ignoreunknown

add call gettext function in the services menu

Fixed #5802
Added collapsible action to config backup

Fix #5794 remove print_info_box_np chackes for gettext("apply")

1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show....

DHCP - Decode value while validating contents

https://forum.pfsense.org/index.php?topic=105654

Fixed #5781

Fixed #5781

add missing space between words

Encode DHCP/DHCPv6 server additional BOOTP text options before save to XML to preserve data. It fixes #5623

EOL spaces

remove leading space

redmine 5702 - switch to high level IPv4 functions instead of low level ip2long32() etc

HTML Compliance - Services / DHCP Server

Bad character after <. Probable cause: Unescaped <. Try escaping it as <.
Ensure one machine's advskew < 20 (and the other is > 20).

Fix redmine #5722 DHCP validation for master

Redundant logic tests in a range check

The logic here is redundant. It tests IP1<START || IP2<START || IP1>END || IP2>END. Then it tests if IP1<IP2 unsigned.

If the latter test succeeds (ie test that first) then IP1>=START must imply IP2>=START and IP2<=END must imply IP1<=END. In other words we only need to test:...

clarify text, might not apply to "NIC" (lagg, VLANs, etc.)

fix part of #5604

Remove $closehead variable

Remove unused variable $closehead

Fix gen_subnetv4_max

and use it in services_dhcp rather than trying to do the similar
calculation in-line.
Should fix redmine #5654 and probably a bunch of other things that use
gen_subnet_max

Tidy up "services_dhcp.php"

- Close TABLE correctly

Code style services dhcp dnsmasq dyndns

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

make text consistent

Type up SCRIPT tags