pfSense

Review fixes.

Enable setting AllowAgentForwarding value

Fixes #8590

Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>

Fixed #9002 - PPPoE Service Name may contain ':'

Avoid creating or parsing a second empty rrddata tag. Fixes #8994

Fix erroneous hostname error for Custom IPv6. Fixes #8977

Change the method used by status.php to mask sensitive info.

Also add a few new tags to be masked. See Factory #1170

Supersede the DHCP MTU when advanced options are present. Issue #8507

Prevent a reference error w/o rules in the config. Fixes #8993

Issue #8974

ssh settings alignment. Fixes #8974

Remove redundant settings stored in the wrong place
Store all ssh settings in the same place
Initialize this array before use

Merge pull request #3990 from luckman212/draggin-v2

Fix typo

Init dnsmasq arrays before referencing. Fixes #8967

gettext on strings

Simplify schedule validation

Merge pull request #3989 from luckman212/wol-default-lan-if

Merge pull request #3981 from NanoCaiordo/NanoCaiordo-patch-1

Merge pull request #3986 from 9Lukas5/master

Merge pull request #3984 from luckman212/gwlb-log-spew

Fix typo in error msg

Fix JSON encoding of gw/gwg params for firewall rule gw list. Fixes #8962

Merge pull request #3992 from luckman212/status-gateways-fixup1

Merge pull request #3980 from luckman212/underscores-on-outbount-nat

Default ACB schedule to every day at midnight

Fixes #8949 Looks like there was 2 variable names for the same variable shownetboot and netboot. It now just uses the variable name netboot

Added scheduled config backup
Fixed: #8947

garga changes
move conditional before platform_booting
and join w && instead of indenting

Fix a display bug in status_gateways.php
This bug causes the Monitor IP to appear even when a gateway
is unmonitored. The monitor IP from the last gateway in the list
to have one will simply get repeated. This patch fixes that bug,
and also cleans up a few other things- unused variables, gets...

default to the lan interface on WOL page, unless another if is
submitted in the form data.

don't show drag message if roworderdragging is disabled

enable ip send for FreeDNS DynDNS update

without this, only legacy IP records get updated correctly.

redmi ticket: https://redmine.pfsense.org/issues/8924

Add missing regex to validate serial

Use all possible kenv variables to detect serial

Fix redirect back to user mgmt when editing user 0. Fixes #8920

Initialize DHCP settings before use. Fixes #8919

Fix #8910: Restore older versions behaviour and consider 'wan' interface as primary default gateway

reduce the tons of log spew that currently spit out during boot
and gateway failure events. Try to make the logs readable again,
while still allowing verbose logging if needed via a new hidden
config option:

['system']['gw-debug']

JimP already fixed it
Revert "Fixed #8913"

This reverts commit fc575f17b66cab903b1241a060180295788e4728.

Fixed #8913

Fix dashboard update check & gitsync settings. Fixes #8913

Fix #8911: Keep configured pkg repository when restoring config

small change to fixup https://redmine.pfsense.org/issues/8851
without this, clicking edit on existing CA goes to wrong screen
and breaks Save button

Init syslog settings before using the array. Fixes #8905

Removed duplicate line :/

Properly restrict a network when default is open.

Effectively override any default setting.

Removed is_ipaddr() as ip_in_subnet() does it already.

Fixed NTP status page not honouring NTP ACLs

Reported in redmine https://redmine.pfsense.org/issues/7609

Don't allow deletion when spoofing another userkey

Fixed #8901

Fix an obvious mistake.

Reported by: stevew
Ticket: #8906
Pointy-hat to: loos

Always pass the $local variabled to load_loader_conf(), it makes the code easier to read.

Sync the know variables with factory.

Filter properly the know variables in loader.conf.

The know variables should be used as prefix not as literals.

Underscores never hurt nobody
Also, i18n

Initialize DHCP settings in setup wizard. Fixes #8889

Rather than assume they are present, create the arrays before use.

Fix a PHP erorr when a CRL has no certificates

Fix typo

Update translation files

Regenerate pot

Fixed #8880

Merge branch 'master' of gitlab.netgate.com:pfsense/pfsense

Revert "Default VTI remote to Address but allow it to change. Fixes #8859"

This reverts commit da54e84ae79328a87b4a319239bb1b14d7ed2ce6.

Prevent a user from selecting VTI for mobile IPsec. Fixes #8877

Changes on the parent interfaces will create new interfaces and the existing VLANs needs to be redone.

Ticket #8527

IPsec VTI requires a manually specified network/address. Issue #8877

Prevent a user from selecting an interface macro like "LAN Network"
which cannot be used with VTI since it does not work like traditional
IPsec Phase 2 definitions.

Fix a PHP error when upgrading gateways

Init gateway group array before use. Fixes #8876

Bump version to 2.4.5-DEVELOPMENT and add 2.4.4 RC repository

Fix #8806: Configure captive portal on secondary identical as master HA node

Fix #8721: Call proper filter_configure function from this class

Change status.php to use "ifconfig -v". Implements #8860

Revise async_crypto setting

Default VTI remote to Address but allow it to change. Fixes #8859

Make async_crypto explicit enabled/disabled rather than current isset

Move IPsec VTI interface cleanup list. Fixes #8858

Generate the cleanup list before the P1 loop but after the initial
interface configuration.

Use safe_mkdir() for IPsec dirs. Fixes #8856

Simplifies the process of making IPsec dirs, though it may not correct
the original reported issue since that appears to be a disk problem,
it's still better/safer than what was done here before.

Initialize IPsec logging array before use. Fixes #8857

Fix #7694: Replace sshlockout_pf by sshguard

Missing line to fix #8850

Set default new CA/Cert action to Create Internal. Implements #8851

Allow packages to opt out of a forced start. Fixes #8850

If a package performs its own service start during its sync process,
then add <starts_on_sync/> to its service definition in the package XML
file. Then when rc.start_packages is called, the forced start will not...

Fixes #8767 PHP7 syntax error

Update translation files

Regenerate pot

Fix Minnowboard Turbot model names. SG-2320 -> MBT-2220, SG-2340 -> MBT-4220

fixes #8837 part 2, initialize as array instead of string for PHP7

Bug was fixed in pfsense module and this code is no longer needed so removing.

$wancfg is not a reference to $config. Set $random_mac properly on config and break long lines while here

Revert ticket #1337

FreeBSD is not happy with simple set VLAN to use a different MAC
address. Revert it for now and prevent users to change VLAN interface
MAC address.

Fix some integer assumptions with calculate_ipv6_delegation_length()

Escape arguments when relinquishing a DHCP lease. Fixes #8843

Fix extra braces

Fixed #8838

Fixed #8837

Add missing break in IpAddress form class. Fixes #8834

Fixed #8812

Perople were misunderstanding "hint" so changed it to "identifier"

PHP7 fixes: Use of undefined constants

Implement #1335:

Let VLANs to have a different MAC address than its parent.

While here also fixes #8138 and do not ignore <spoofmac> for interfaces
without hwaddr field

Do not let users change QinQ mac address