pfSense

Correct check IP service config path.

Revert "Pass reloadall flag to dhcp6c config. Fixes #13253"

This reverts commit 8e88bd48a22b55d213ac7613be74c651706cfa0d.

Always declare $config global in case a script is included in a non-global scope

$config is expected to always be a global containing the parsed configuration,
however in the sources that it is assigned a value in toplevel scope it is not
explicitly declared as such. As a result, if one of these sources is included in...

Fix more config access regressions in filter.inc. Fix #13754

Correct DHCP lease reg enabled test. Fixes #13782

Revert "Fix more config access regressions in filter.inc. Fix #13754"

This reverts commit c0d7519df5dc1632ba9f2791ab377bdc19f45105.

Fix more config access regressions in filter.inc. Fix #13754

Redo Unbound ACL action handling. Fixes #13767

Remove trailing whitespace

Remove cxl from altq capable interfaces list

Improve handling of empty DDNS entries. Fixes #13581

UPnP rule/service cleanup. Fixes #13755

• Fix several incorrect config paths/tests
• Fix UPnP local interface automatic rule to pass traffic into UPnP
  itself.
• Wrap all rules/anchors in UPnP enabled test, no reason for them to be
  in the ruleset if UPnP is off....

Fix config access regressions in filter.inc. Fix #13754

Fix direct config accesses in unbound for php81

Restore default description behavior. Fix #13739

Remove leftover debug prints.

Work around for empty config tags. Fixes #13564.

Related to issue #13642, the serialization of route maps was broken for a time
in such a way that the frrglobalroutemaps tag would contain only a single empty
config tag. The xml parser element handler considers 'config' to be a 'list...

globals.inc needs to be sourced in auth_func.inc

Rector direct global g accesses

Use correct UPnP enabled test. Fixes #13735

Use rtrim for trimming whitespace and EOLs from version files

Cleanup globals.inc. Use single quotes on scalar strings.

Eliminate some direct config access in util.inc, add some documentation

Add append hook to globals.inc.

Introduce public accessors for $g: g_has, g_get, and g_set.

Improve LDAP debug logs. Implements #13718

Revert "Remove unused global $config_extra"

This reverts commit e36bc382ae1e0533c328b9dcd99959b17171de2e

Remove unused global $config_extra

Remove unused xmlreader implementation and conditional sourcing

Add ovpn qinqs to bridges instead of rebuilding them. Fixes #13666

qinq interfaces defined with parent openvpn interfaces are configured late in
rc.bootup, after qinqs for other physical and logical interfaces and bridges are
configured. The resolution to #13225 ensured that these late interfaces were...

rc.ipsec: Strip bonus quotes. Fixes #13076

The string was coming from check_reload_status wrapped in quotes that
were not necessary, and were causing the string to not match when it
should have.

Rector some direct config gets with complex paths.

Pass reloadall flag to dhcp6c config. Fixes #13253

This ensures that if the interface is being configured in a way that requires a reload, that the DHCP6 client is also restarted. This allows the DHCP6 client to restart when applying settings and during other necessary events.

Rector some config unsets with complex paths.

DDNS Save+Force timeout improvements. Fixes #12870

• In PHP8, curl_close is a no-op, so remove it.
• Now that curl_close does nothing, we have to set CURLOPT_FORBID_REUSE
  to prevent connections from getting stuck in a pool waiting for reuse.
• Add a couple more debug log entries for when certain functions end,...

Rector some direct config gets with pure scalar paths.

Rector some more direct config unsets with pure scalar paths

Fix regression in URL alias parsing. Fixes #13685

Correct special net NPt dst prefix handling. Fixes #13240

Disables prefix length drop-down when using a special net (e.g. track6
delegated prefix) because that already has its own prefix length.

Being able to specify a custom prefix was of dubious use and served to...

Add CDATA protection to "hint". Fixes #13388

rc.linkup code refresh and fixes. Fixes #13254

• Update code to be more compatible with PHP 8.1
• Consistency changes to code and logging so every path has similar
  output instead of some being unusually different.
• Do not restart unbound on linkup as other mechanisms already do that...

Restore unintentionally removed line. Issue NG 9247

Fix gif interface _routerv6 files not being created. Fixes #11545

interface_gif_configure() uses the global variable $g to look up the temp
directory in which to write the router/gateway files used for gateway
monitoring. The declaration of $g in this scope was inadvertently removed in...

Add iface to some resolver restarts. Fixes #12612

A few interface-specific calls to restart the resolver were not passing
the interface name to ensure it was only restarted when necessary.

Fix PPP reset hr/min blank vs 0. Fixes #13307

Correct console set IP addr script. Fixes #12632

• Prompt to replace default gateway instead of only setting if it was
  empty before.
• Correct faulty assumptions about WAN or LAN interfaces and either
  remove unnecessary checks or change so they look for presence of a...

Fix Adv DHCP6 f/multiple interfaces. Fixes #13462

Improve set_ipv6routes_mtu checks. Fixes #13675

Define curl CAPath for trusted CAs. Fixes 12737

Disabled service status correction. Fixes #13604

Merge pull request #4604 from luckman212/fix-func-args-in-gwlb.inc

Removed unused filter_flush_nat_table, fix typo. Fixes #12757

Spelling fixes. Fix #13357

• Incorrect input validation for `dhcp6c` `keyinfo expire` `forever` keyword in `interfaces.inc`.
• Incorrect input validation for associated rule's `Source Port` in `firewall_rules_edit.php`.
• Incorrect `voucher*.` file lock reference in `status_captiveportal_voucher_rolls.php`....

Merge pull request #4596 from luckman212/update-rc.initial-202206

Merge pull request #4606 from KoenZomers/DNSExitFix

Merge pull request #4605 from kaedros/master

Remove duplicate reserved alias names. Fix #13524

Respect bind interfaces in unbound. Fix #13393

Also create DHCPv6 rules for interfaces with static IPv6. Fix #13633

Correct typo. Fixes #13663

While here, reduce a few differences with Plus.

Update the loader.conf filter list.

This remove the duplicate entries for the settings added by pfSense.

Sync with the current Plus defaults.

Correct codelq shaper input validation for firewall_shaper.php. Fixes #13661

Ensure all bandwidth values are cast to int before applying arithmetic to the
return value of get_bandwidth_typescale(). This alleviates failed validation
when the bandwidth is blank....

Misc EasyRule updates/fixes.

• Addresses several known issues in EasyRule. Fixes #13445
• Updates syntax to new style for PHP 8.1. Fixes #13627

Fix config_del_path() if the node doesn't exist

If the node we're trying to delete with config_del_path() doesn't exist
array_del_path() will fail as follows:

Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /etc/inc/util.inc:3459...

Add bxe to the ALTQ capable interfaces list

Redmine: #13304

Rewrite functions for toggle & delete NAT. Fixes #13545

Refine IPsec deprecation behavior. Issue #13648

P1 and P2 entries are only disabled if they have no remaining valid combinations of options. This way tunnels that just had one bad entry selected can continue working.

Replace some direct config accesses in util.inc. Fixes #13640

Remove cxgbe (cc) from the ALTQ capable list

Despite what the relevant man page claimed (now fixed) the cxgbe driver
has not supported ALTQ since 2012. Do not allow ALTQ to be enabled on
those interfaces.

This reverts b3979f4abe9ecb2bdd59cbbcb61e3eccf9180b79....

Remove invalid quotes from charon attr plugin attributes. Fixes #13579

Fix setting EFI boot console type. Issue #13080

For some reason the EFI loader is forcing boot_serial=YES when it is not
set in the loader configuration. To work around this, we must set it to
NO explicitly. The loader menu displays the wrong type still but it...

ipsec: disable any tunnels using 3des, blowfish, cast128 or md5 during upgrades

Redmine: #9247

ipsec: remove obsolete algorithms

These are no longer supported in FreeBSD main. Ensure they can no longer be configured.

Redmine: #9247

ipsec: allow CHACHA20-POLY1305 to be configured

Redmine: #9246

openvpn: don't IFF_UP the new tun interface

New openvpn versions set TUNSIFMODE, which FreeBSD's if_tuntap only
allows on interfaces which are not up.

So, don't up the tap interface when we create it. Leave that to openvpn
itself.

Redmine: #13602

Fix config path typo when installing firewall schedule cron job. Fixes #13605

Fix array initialization in rc.initial.setlanip. Fixes #13583

Remove direct $config accesses form rc.filter_synchronize. Fixes Issue #13446

Skip empty dnsmasq custom options

Fixes for problematic config access in rc.initial.setlanip. Fixes #13583

More PHP81 fixes for gwlb.inc. Fixes #13563

Omit irrelevant info from auth error. Fixes #13574

Fix LDAP authentication for PHP8.1. Fixes #13559

Fix shaper.inc for PHP81. For #13553

PHP81 fix in gwlb.inc. For #13514

Update dhcp rule description

Update reserved alias names. Fix #13524

Initialize $groups in local_user_get_groups to non-null. Issue #13446

Fix handling of empty entries in NTP interfaces.

Prevent array/config_get_path() from overriding 0 values

Change the semantics of array_get_path() and config_get_path() so that only
empty strings at a path are overridden by $default if non-null, so that
legitimate 0 values set in the config are not overridden as empty() returns true...

Replace direct config accesses in auth.inc. Issue #13446

Additionally, change local_group_del_user() to include the index of the group in
the path to the group's member list when removing the user from it. This appears
to have been broken in the original code. With this fixed, remove the redundant...

Avoid using -a in test(1)

-1 is not allowed, exit only uses 0-255

Always set interface-automatic in unbound config. Fix #13393

Fix array_get_path() not returning $default for null-like values. #13446

In array_get_path(), a $default provided that is not null is intended to invoke
alternate behavior where if the path exists and is empty, $default should be
returned. This requires not identical compare as opposed to a not equal compare,...

Fix DDNS GW check PHP error

We need to get the status value from the returned array, not use the
array itself.

Revert "Workaround new pkg(8) behavior causing files with "NULL" in the path to be..."

This reverts commit 8b7ab58088f15bec9f9d5cede5fdcd8e3b9fe10e

Workaround new pkg(8) behavior causing files with "NULL" in the path to be skipped on install. Fixes #13394.

qinq: use if_vlan rather than netgraph

if_vlan now supports QinQ, so use that rather than netgraph. This is
expected to perform better, removes a subsystem dependency and
simplifies the php code as well.

Note that this is not possible on stable/12.