pfSense

Update copyright years to include 2023

Rector direct global g accesses

Rector some direct config gets with complex paths.

Rector some config unsets with complex paths.

Rector some direct config sets with pure scalar paths.

Rector some direct config gets with pure scalar paths.

Update/cleanup DHCP 4/6 server text. Fixes #13250

Fix saving dhcp6c-dns setting in services_dhcpv6.php. Fixes #13594

services_dhcpv6.php: Fix a PHP81 config access error

DHCP/v6 PHP8 error fixes for some cases.

If a config starts with only WAN, no LAN assigned, there are a number of
tags that were not handled properly on DHCP, DHCPv6, and RA.

Fixed up some other unrelated low-hanging fruit while I'm here, but all
of these files need a lot more work for PHP8.

Clarify delegated IPv6 prefix source. Fixes #13310

Indicates the tracked interface and prefix ID, which is more important
now that delegation works from multiple upstream sources.

more spelling fixes

more accurate error message

fix a spelling mistake

max dhcp lease can be equal to the default lease

Update the Copyright year of the files owned by Rubicon/Netgate.

Do not allow to select PPPoE Server interfaces on the DHCPv6 Server page. Fixes #12277

Update the Copyright year.

A subsequent commit will deal with .po's.

Create poesX interfaces for PPPoE server. Issue #11034

Fix #204: Add messages to all write_config() calls

Track Interface / PD improvements. Issue #5999

DHCPv6 Static Mapping fix. Issue #10882

DHCP service DDNS key name RFC2845 compat. Fixes #10844

DHCPv6 service Dynamic DNS fix. Issue #10346

DHCPv6 range is not mandatory for Stateless DHCP. Issue #9596

Feature #9661

Reword option help text for issue #9302

This is 2020. Issue #9245

3rd try - change config names

2nd try
change config option to avoid positive checkbox = negative option

Add opts to services_dhcpv6.php and services_router_advertisements.php

Adds config options to disable pushing DNS server options to dhcp6
clients via dhcpd or radvd. Fixes an issue when using split-horizon
DNS with dnsmasq via `localise-queries` option since that supports...

Apply the same fix from issue #8469 to DHCPv6. Fixes #9448

Fix copyright message years to reflect BSDP -> ESF -> Netgate

Fix empty lines in forms

Fixes a number of empty lines in forms by adding hidden inputs using
`addGlobal` on the form instead of `addInput` on sections or `add` on
groups.

Update copyright notices to 2019. Happy New Year

Fix #9121: Initialize arrays to prevent PHP 7 errors

Remove obsolete OLSRD code. Implements #9117

Fixes #8949 Looks like there was 2 variable names for the same variable shownetboot and netboot. It now just uses the variable name netboot

Fixes #8714 PHP7 illegal string offset error

Fixed #8678

Fixes #8659 PHP7 Illegal string offset and count

Update the Copyright notice for pfSense.

Fix input field help texts

Add DHCP Dynamic DNS key algorithm choice. Implements #6621

Add missing $zone variable

Update BIND zones when adding static DHCP leases if needed (Bug #3710)

GET/POST conversion - services part 1

setHelp strings for services*

Code with multiple %s in usr/local/www

Required fields in Services pages

Always force compress when calling Net_IPv6

Merge pull request #3369 from phil-davis/breadcrumbs_detail

Breadcrumb links

Report problems applying changes

1) Strictly keep track of the accumulating $retval from calls to various
functions that apply changes.
2) Use new function print_apply_result_box() to print a suitable message
in a suitable severity based on $retval

Standardize privilege name capitalization

While looking at some privilege stuff, I noticed that various
capitlization looked inconsistent down the list. This makes the list
look more consistent.

Merge pull request #3266 from PiBa-NL/IPv6-prefixdelegation-size59

IPv6, allow DHCP6 server to use a prefix size of /59 and /61 like dhcp client does

DHCPv6 server edit when DHCPv6 Relay enabled

Part of Redmine #6997
This implements the similar behaviour as for the DHCPv4 server in Pull
Request https://github.com/pfsense/pfsense/pull/3271

Clarified help text for ddnsforcehostname option.

Added title to ddnsforcehostname checkbox

Add ddnsforcehostname option to DHCP6 Server configuration editor

DHCPv6 ddnsdomainprimary must currently be IPv4

This field is currently validated to allow only an IPv4 address to be entered, so it may as well be consistent client-side so the user knows that only an IPv4 address is allowed.

DHCPV6 only check VIPs in range if range valid

If the user has input invalid values into range from and to, then there
is no point checking any IPv6 VIPs to see if they fall in the range.
None of them would be "in range" because the specified range is not even...

Move copyright from ESF to Netgate

Uniformize memory limits and remove old code (revised)

1) Allow setting a memory_limit up to 768M (Suhosin)
2) Remove old workarounds. Memory limits on config.inc will be new defaults

Move to Apache License 2.0

Review license / copyright on all files (final round)

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Miscellanous Textual Corrections - Add missing dots, normalize case

Miscellanous Textual Corrections - Add missing dots to phrases

Merge pull request #2814 from NOYB/Services_/_DHCP_-_Remove_Personalizations

Allow configuring RAs when DHCPv6 Relay is enabled. Ticket #6063

Services / DHCP - Remove Personalizations

Remove "you" personalizations.

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

Redmine #5972 Display Advanced settings on page load

If there are non-default advanced settings, then the relevant fields are displayed on page load.
Advanced button behavior is standardized as described in redmine #5994

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Resolve conflicts with master

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

Fix $POST checks so they do not depend on string Save

This prevents problems when Save is translated to other languages.
Note: This is the only remaining place I could find with this issue.
There are other pieces of code that do:
```
if ($_POST['save'] == gettext("Save"))...

Fix some Save button quirks. Ticket #5965

Advanced button consistency. Ticket #5965

More icon and button consistency fixes. Ticket #5965

Fixed 5971

Icon consistency in Repeatable blocks. Ticket #5965

A PD-obtained subnet is always a /64 on the interface, so should be shown as such here in DHCPv6 server. Ticket #3029

Hide additional bootp options when it's disabled, fixes #5914

Fix indent

Move the DHCPv6 apply action into a function. Capture the apply and save actions separately and only perform the required task. Fixes #5910

Fixed #5914
COntrol panels via jQuery for more control

clean up text

DHCPv6 clean ups for PD. Ticket #3029

Ticket #3029

Fix DHCPv6 GUI to work with PD length != 64

Ticket #3029

Import patch from @Robert-Nelson to enable DHCPv6 Server/RA to
interfaces configured to track DHCP-PD

This patch only works for PD with length 64

Make prefix delegation range check case insensitive

Unbreak services_dhcpv6.php

Validate Prefix Delegation range to make sure addresses match first network address, otherwise DHCPd will silently fail

Fix range and prefix delegation range help text to match From/To in correct order

Simplify logic

Simplify logic

Fix #4675

Following bugs and improvements on DHCPv6 DDNS area, obtained from
PR #1638 from @Robert-Nelson:

- Use correct domain (ddnsdomain) instead of (domain)
- The option "deny client-updates" wasn't being set so forward entries
weren't being added. Allow user to chose between allow, deny or ignore...