pfSense

Revise firewall schedule delete for MVC

Change pkg install variable references. Fixes #11290

• For whatever reason, PHP was failing to copy certain values into
  $pkg_data which was a reference to the pkg configuration, so drop that
  and use the $config variable directly.
• While here, fix initialization of pkg tab contents...

Fix state table content sorting. Fixes #11852

OpenVPN Wizard: Enable exit_notify by default

Follow up with fix for ticket #11684 and also enable it on server
tunnels created using wizard

Simplify logic: no functional changes

Outbound NAT: Fix rule duplication - #11981

- firewall_nat_out.inc: Declare $after as a global variable otherwise
duplicate rule will always end up at the bottom
- Do not set $id and $after with dup parameter value when save button
was pressed or it will replace rule instead of duplicate it

Adjust validation for MVC

Revise top/bottom outbound rule addition

Simplify getting automated rules

AutoConfigBackup schedule custom hour value fix. Issue #11946

FRR help links. Fixes #11943

Correct RADVD log message on HA event. Fixes #11966

Allow to use numeric with decimal point for RADIUS Advanced Parameters. Feature #11211

Minot MVC improvements

Use 'tos' rather than 'dscp' keyword for pf DSCP matching

The 'dscp' keyword is pfSense-specific, but doesn't do anything more
than the FreeBSD 'tos' keyword.
Using 'tos' will let us remove a diff from our local FreeBSD branch.

schedule: Use the new multi-label support

We've removed the pfsense specific 'schedule' keyword, and now use the new
multi-label support. That is, schedules are now just another label (prefixed
with 's:'). We also use the classic pfctl kill option (-k) rather than...

Tell pf to keep counter values

Pf can attempt to preserve (rule) counter values across rule updates.
We've reverted our home-grown implementation and switched to the upstream
implementation. We must tell pf to actually do this, so 'set keepcounters'.

Duplicating Outbound NAT rule fix. Issue #11981

Create Outbound NAT automatic equivalent rules when switching from Automatic to Manual mode. Fixes #11982

Observe 'after' value when creating a new rule

Init pkg plugin array before use. Fixes #11290

Make VLAN table sortable. Implements #11968

Move globals to include file

Move globals to include file

Validate input depends on flag

Toggle-rule rename var for consistency

Toggle-rule returns new ruke status

ipsec: Simplify logic

ipsec: Use correct variable name

ipsec: Remove unneeded references on parameters

ipsec: Normalize ipsec_lookup_phase1()

- $ph2ent doesn't need to be a pointer
- Return true when $ph1ent is found since $ph1ent is a pointer and is
filled with proper content in this case

Add missing vars to applyVIP(). Fixes #11723

IPsec ipsec_create_vtimap() fix. Issue #11945

Fix PHP error when changing Sys Info Widget. Fixes #11939

Avoid attempting to use $crypto when it's empty/undefined.

1:1 NAT IPsec/OpenVPN/L2TP/PPPoE and interface groups input validation extra 2.6 fix. Issue #11751

NAT 1:1 destination alias validation. Fixes #11923

Refactor firewall_nat_out for MVC

Further simplify update check

Revise update check JSON format

Back out recent changes in mobile IPsec

These changes led to the pool failing to load and thus clients could not
connect. Will revisit for future releases. Affects:

• Issue #11447
• Issue #11891

Revert changes for issue #11091

Report file system type in metrics

Refactor firewall_nat_npt for MVC

Refactor firewall_nat_1to1_edit for MVC

Refactor 1 to 1 NAT for MVC

One.com, NIC.RU, Yandex DynDNS support. Implements #11293 #11294 #11358

Set explicit-exit-notify to 1 for new OpenVPN Server instances. Issue #11684

Fix missing ')' in openvpn.inc

Merge pull request #4515 from znerol-forks/feature/master/radvd-linklocal-vip-2

Unbound devfs mount check. Fixes #11456

NTP status widget fix. Issue #11495

Merge pull request #4509 from JonathonReinhart/floating-rule-no-matching-iface-master

PPPoE custom reset crontab entry fix. Issue #11698

Set default OpenVPN inactive timeout to 300. Issue #11699

Set default_socket_timeout on XMLRPC sync. Fixes #11718

saveVIP() fix. Issue #11723

Checking multiple backups when detecting invalid configuration. Fixes #11748

Include Chelsio temperature values.

https://redmine.pfsense.org/issues/11787

Do not start an OpenVPN instance if vip aliased to BACKUP CARP. Fixes #11793

Merge pull request #4518 from bauerstefan/master

NoIP.com DynDNS fix. Issue #11815

openvpn.tls-verify.php fixes. Issue #11830

ipsec_vti() skipdisabled fix. Issue #11832

Refactor hide logic for fields on DynDNS edit page. Fixes #11840

The page included hide/show logic for username field only for few
providers, which meant that if a provider with the hide logic was
selected, then the field was lost for all others too. This commit...

Correctly change default IPv6 route MTU if both IPv4/IPv6 gateways are configured on interface. Fixes #11855

OpenVPN TAP ifconfig-ipv6 syntax fix. Issue #11869

Merge pull request #4517 from vajonam/fix_address_clone

DHCP6: Do not wait for a RA & Advanced Configuration script fix. Issue #11883

IPsec Dashboard widget improvement. Fixes #11893

Change firmware update message text. Issue #11897

Do not restart IGMP Proxy on IPv6 gateway events. Fixes #11904

Add QEMU and KVM detection to system_identify_specific_platform()

Merge branch 'viktor/pfSense-nat11ipsecfix'

Merge branch 'viktor/pfSense-defaultipv4llfix'

Merge branch 'viktor/pfSense-ng6255fix'

Merge branch 'viktor/pfSense-11873fix'

Merge branch 'viktor/pfSense-quotecshproxyvariables'

Merge branch 'viktor/pfSense-11850fix'

Merge branch 'viktor/pfSense-ipsecvtidisable'

Merge branch 'viktor/pfSense-sanitize_pass_radmac_secret'

Merge branch 'viktor/pfSense-noticeshtmlencfix'

Merge branch 'viktor/pfSense-tcpflagsinputvalidation'

Merge branch 'danilo/pfSense-bug11754fix'

Merge branch 'viktor/pfSense-codelqlimitfix'

Merge branch 'viktor/pfSense-delovpndnsonboot'

Show Export P12 icon if certificate is not locally renewable. Fixes #11884

Radvd config page reload/logs buttons. Fixes NG #6255

HTTP Referer Message accurate path. Fixes #11873

Quote proxy user/pass variables in dot.tcshrc. Fixes #11867

NTP Authentication key input validation fix. Issue #11850

Delete OpenVPN DNS entries on boot. Fixes #11704

CODELQ scheduler Qlimit input validation. Issue #11725

1:1 NAT IPsec/OpenVPN/L2TP/PPPoE and interface groups input validation fix. Issue #11751

Firewall Rule TCP flags input validation. Fixes #11762

Notices modal window HTML encoding fix. Issue #11765

Sanitize pass and radmac_secret. Fixes #11767 and #11769

Allow to disable IPsec PH1 when related P2s are in VTI mode and enabled. Fixes #11792

IPv4 link-local (169.254.x.x) gateway fix. Issue #11806

IPsec multiple identical P1 tunnels input validation improvement. Fixes NG #6010

Kill IPv6 client states on OpenVPN disconnect. Implements #11700