pfSense

Fix PHP errors from empty DHCP configs. Fixes #13983

Update copyright years to include 2023

Fix DHCP server ping check option. Fixes #13748

Rector direct global g accesses

Replace direct config access in services_dhcp.php. Fix #13719

Rector some direct config gets with complex paths.

Rector some direct config sets with pure scalar paths.

Update/cleanup DHCP 4/6 server text. Fixes #13250

DHCP/v6 PHP8 error fixes for some cases.

If a config starts with only WAN, no LAN assigned, there are a number of
tags that were not handled properly on DHCP, DHCPv6, and RA.

Fixed up some other unrelated low-hanging fruit while I'm here, but all
of these files need a lot more work for PHP8.

more spelling fixes

more accurate error message

max dhcp lease can be equal to the default lease

Fix disabling dhcpd rrd stats. Issue #12710

Update the Copyright year of the files owned by Rubicon/Netgate.

Support for UEFI HTTP Boot option in DHCP config. Implements #11659

Replace HTTP links to HTTPS. Implemets #11228

Update the Copyright year.

A subsequent commit will deal with .po's.

Fix #204: Add messages to all write_config() calls

Save OMAPI settings in dhcpd.conf. Issue #10270

Create key and zone section for static DHCP mappings. Issue #10224

DHCP service DDNS key name RFC2845 compat. Fixes #10844

Hide ARM32/64 network booting options. Issue #10374

Add ARM netboot to services_dhcp.php. refs #10374

DHCPv6 service Dynamic DNS fix. Issue #10346

DHCP Domain trailing dot validation. Issue #8054

Add static mapping count to DHCP Server interface tabs. Issue #9282

Feature #9661

DHCP group known clients by interface. Issue #1605

This is 2020. Issue #9245

Fix #7304: Add OMAPI to the DHCP Server settings

Supports setting a port and setting or generating a key. Service is
enabled when settings are defined. Validation logic added on save to
verify port is valid and not in use as well as that a key is defined or...

Remove redundant if

Fix copyright message years to reflect BSDP -> ESF -> Netgate

use disablepingcheck as option name

add an option to the DHCP server to disable the ping check feature

Update copyright notices to 2019. Happy New Year

Fix #9121: Initialize arrays to prevent PHP 7 errors

Remove obsolete OLSRD code. Implements #9117

Fixes #8732 PHP7 illegal string offsets

Correct the DHCP DNS reg check. Fixes #8120

Now allows all but one DHCP server to be disabled, rather than denying
all of them.

Restrict entry of DHCP options (ticket #8534)

PHP7 - services->DHCP resolve warning

Bug #8469 - Modify show_advdns function pageload conditions to allow for ddnsdomainkeyalgorithm default value, i.e., hmac-md5

Add DDNS client update option to DHCPv4 configuraiton

Update the Copyright notice for pfSense.

Fix input field help texts

Add DHCP Dynamic DNS key algorithm choice. Implements #6621

Checks for DHCP Relay being enabled/disabled should be skipped when editting an additional pool

Add missing $zone variable

Update BIND zones when adding static DHCP leases if needed (Bug #3710)

Check that DHCP registration isn't enabled for DNS forwarder/resolver when disabling DHCP server

GET/POST conversion - services part 1

setHelp strings for services*

Part Fix #7233 Allow deletion of empty static map entries

Required fields in Services pages

Display client id in DHCP Mapping list

Merge pull request #3369 from phil-davis/breadcrumbs_detail

Breadcrumb links

Report problems applying changes

1) Strictly keep track of the accumulating $retval from calls to various
functions that apply changes.
2) Use new function print_apply_result_box() to print a suitable message
in a suitable severity based on $retval

Merge pull request #3307 from blkeller/ignore-client-uids

Merge pull request #3248 from phil-davis/ipaddressnopattern

Modify DHCP Server messages

Customize DHCP Server on interfaces message

Fix field type for TFTP in DHCP server settings

Add new "Ignore client identifiers" DHCP feature

Exposes the underlying dhcpd configuration option "ignore-client-uids"
in the pfSense "Services / DHCP Server" GUI by adding an "Ignore client
identifiers" checkbox.

As of ISC dhcpd version 4.3.0+, there is a new configuration statement...

Disable DHCP server on interfaces with subnet >= 31. Fixes #6930

DHCP server edit when DHCP Relay enabled

Part of Redmine #6997
1) Display the DHCP Server settings even when DHCP Relay is enabled, but
disable the "enable" checkbox in this case - so the user cannot enable
DHCP Server when DHCP Relay is enabled, but can view and modify the DHCP...

Form_IpAddress add types remove patterns

1) Add alias and host types to Form_IpAddress with the appropriate hover
text.
2) Remove the patterns - the UI of those is not so effective anyway, so
leave the validation of input to the back end.
3) Update uses of Form_IpAddress to use the appropriate Alias or Host...

Clarified help text for ddnsforcehostname option.

Added title to ddnsforcehostname checkbox

Add ddnsforcehostname option to DHCP Server configuration editor

Improve IPv4 address validation for services_dhcp

The input pattern that goes with Form_IpAddress by default allows for IPv4 and IPv6 valid characters. The back-end validation here is checking for IPv4 addresses, so it seems reasonable that the front-end input pattern checks might as well be restricted to the IPv4 valid characters. Unneeded setPattern have also been removed....

Merge pull request #3151 from EdHurtig/eng/6806

Typo staic

Apply static ARP entries more consistently when adding and removing static mapping entries. Fixes #6821

Allow Hyphens in DHCP NTP Server form validation

Also removes the ability to have underscores `_` in ntp server
FQDNs.

Closes #6806

Move copyright from ESF to Netgate

Merge pull request #3083 from doktornotor/patch-2

services_dhcp: Ignore BOOTP queries

BOOTP leases do not have a maximum lease time by default, this could
potentially lead to a DHCP address pool exhaustion.

This commit adds an option to ignore BOOTP queries.

Redmine #4351

Allow URLs for TFTP Server (Bug #6634)

The setPattern() thing ain't usable for this and just causes regressions.

Typo fix

Allow URLs for TFTP Server (Bug #6634)

is_URL() from util.inc is way too limited for this purpose.

Clarify that HMAC-MD5 key is required. Ticket #6622

Move to Apache License 2.0

Review license / copyright on all files (final round)

Fix #6050 DHCP - provide Network Booting display/hide advanced button

This one moves the "Network Booting" above the "Additional BOOTP/DHCP Options". That allows "Network Booting" to be a Display/Hide Advanced group of buttons just like TFTP, LDAP etc. (without a special section header) and for "Additional BOOTP/DHCP Options" to come last on the page.

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Fixed #6504 by making table sortable

Allow - in TFTP Server field. Ticket #6433

Miscellanous Textual Corrections - Add missing dots, normalize case

Fix missing interface in pool edit. Ticket #6303

Hostnames are valid for NTP servers in DHCP Server. Ticket #6239

Services - Punctuation

Clean up some services menu punctuation.

Services / DHCP Server - DNS Servers Clarification

It reads as though the interfaces IP address is to be entered. Removing "use" makes it a little clearer.

Services / DHCP - Remove Personalizations

Remove "you" personalizations.

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

HTML Compliance - Services / DHCP Server

Error: The align attribute on the td element is obsolete. Use CSS instead.

servise_dhcp include btnadvopts in section

Before this change, $section is added to $form before btnadvopts is put into $section. The previous code looked to me like btnadvopts would end up in a $section object that got overwritten by the new Form_Section at line 1165....

Redmine #5994 Make DHCP advanced buttons work consistently

This is the first UI page to be changed so that the Advanced buttons work as specified in Redmine #5994
If this seems like a reasonable way to do it, then I will make similar code for the other UI pages with Advanced buttons.

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.